-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update CI actions #1044
chore: Update CI actions #1044
Conversation
@XhmikosR is attempting to deploy a commit to the Package Phobia Team on Vercel. A member of the Team first needs to authorize it. |
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the filename the same so we can see the diff here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the patches selarate for this reason.
uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node }} | ||
- run: corepack enable npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep corepack so it runs the correct version of npm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I also restored npm --version. I wasn't aware of this feature, you learn something new everyday :)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets change this PR to adding dependabot only.
I don't like the other changes since its not clear the benefit.
Well, there's no permissions specified (which could be even less later), newer actions versions, no more useless matrix and the use of https://www.diffchecker.com/4IH8J4Kj/ Feel free to close if you only want the dependabot addition. I personally think the other changes are good. |
TODO: