Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI actions #1044

Closed
wants to merge 7 commits into from
Closed

chore: Update CI actions #1044

wants to merge 7 commits into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Apr 20, 2024

TODO:

  • Adapt branch protection rules before the merge

Copy link

vercel bot commented Apr 20, 2024

@XhmikosR is attempting to deploy a commit to the Package Phobia Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the filename the same so we can see the diff here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the patches selarate for this reason.

@XhmikosR XhmikosR marked this pull request as ready for review April 22, 2024 05:39
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- run: corepack enable npm
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep corepack so it runs the correct version of npm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I also restored npm --version. I wasn't aware of this feature, you learn something new everyday :)

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
packagephobia ✅ Ready (Inspect) Visit Preview Apr 25, 2024 10:37pm

Copy link
Owner

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets change this PR to adding dependabot only.

I don't like the other changes since its not clear the benefit.

@XhmikosR
Copy link
Contributor Author

Well, there's no permissions specified (which could be even less later), newer actions versions, no more useless matrix and the use of npm ci and caching.

https://www.diffchecker.com/4IH8J4Kj/

Feel free to close if you only want the dependabot addition. I personally think the other changes are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants