Refactor triangle to use calc() #616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roginfarrer
commented
May 19, 2022
| @@ -1,4 +1,4 @@ | |||
| #!/bin/sh | |||
| . "$(dirname "$0")/_/husky.sh" | |||
|
|
|||
| lint-staged --debug | |||
| yarn lint-staged --debug | |||
There was a problem hiding this comment.
I can omit this. But I thought it odd that the repo requires lint-staged be installed globally when it's a dependency of the project.
roginfarrer
commented
May 19, 2022
| @@ -267,7 +267,7 @@ describe('triangle', () => { | |||
| ) | |||
| }) | |||
|
|
|||
| it('should throw an error when height or width is not a unit based value.', () => { | |||
| it.skip('should throw an error when height or width is not a unit based value.', () => { | |||
There was a problem hiding this comment.
Q for the reviewer, do we want to keep this check, but then also explicitly check for a value starting with var(--?
Codecov Report
@@ Coverage Diff @@
## main #616 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 89
Lines 860 858 -2
Branches 323 320 -3
=========================================
- Hits 860 858 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triangle()currently expects height and width values that are a string value with a unit (e.g.'12px') or a number (12). It throws an error otherwise.This prevents the use of CSS custom variables. However, if we change from using JS arithmetic to CSS
calc(), we can support CSS variables, in addition to number of unit values, without having to do any unit stripping in strings.