remove className usage checker & suppression prop #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxstbr
approved these changes
May 29, 2019
| @@ -74,7 +72,7 @@ class StyledComponent extends Component<*> { | |||
| // eslint-disable-next-line no-console | |||
| console.warn( | |||
| `Functions as object-form attrs({}) keys are now deprecated and will be removed in a future version of styled-components. Switch to the new attrs(props => ({})) syntax instead for easier and more powerful composition. The attrs key in question is "${key}" on component "${displayName}".`, | |||
| `\n ${(new Error()).stack}` | |||
There was a problem hiding this comment.
Is there a reason why it was this way, maybe browser compat? Is this safe to change?
There was a problem hiding this comment.
idk, prettier removed it so I assume a safe transform
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It ends up creating a ton of dev noise in nextjs due to usage of React loadable and breaks things like React strict mode for which there is no current corollary.
Fixes #2154