-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style prop accepts function in native components for v5 #3389
Fix style prop accepts function in native components for v5 #3389
Conversation
18c11ba
to
984b2bf
Compare
984b2bf
to
93a2dd6
Compare
Would love to see this get merged as soon as possible as it's quite an annoying issue with what seems to be a fairly simple fix 😅 @probablyup apologies for pinging you but is it possible to get this merged and released into v5? 🙏 EDIT: Although I suppose it might be nicer if we could somehow access the |
If you're unfamiliar with React Native and have trouble to maintenance the related codebase, would you mind inviting me maintainer? I'm familiar with it so, maybe help you for that. |
Nevermind found it. Code looks good, could you add a changelog entry and I'll merge? |
…nents into fix/3384_style_function_prop_for_v5
fd06f6a
to
1fbfc4f
Compare
@probablyup Thank you for a reply. I did it. |
@probablyup Any chance we can get this merged in? |
This PR for v5 branch of style prop bug fix already v5 Pressable released. More detail #3388.
Review in the way it says. Only difference is to checkout fix/3384_style_function_prop_for_v5 in submodule.