[fix] COMPLEX_SELECTOR_PREFIX.includes wasn't transpiled #3397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLEX_SELECTOR_PREFIX.includes wasn't transpiled,
causing issues in Internet Explorer 11 due lack of compatibility.
The fix is just replacing it for indexOf, in the meantime, the solution is to roll back to v5.2.0
CAUSE
The transpilation done with babel is not transpiling deep enough, as other Array.prototype.includes are being correctly transpiled, this single one (maybe because of being in the middle of an if statement or something fancy like that) seems to not be transpiled.
EFFECT
IE 11 is not compatible with this property of the array object, producing an error.
TEST
Compile the project and search for ".includes" in the minified file.
FIX
Replacing ".includes" for ".indexOf" for compatibility
PREVENTION
Consider adding some bundle validation as part of the Pull Request validation, making sure your bundle transpiles correctly for the browsers supported before merging into master.