Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interleaveWithNodeStream streaming flow to be compatible with React 18 api #4213

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ignatiqq
Copy link

@ignatiqq ignatiqq commented Nov 12, 2023

As mentioned here - #3658
And here - #4211

New React "renderToPipeableStream" stream api decides how much HTML to send by itself and it’s not a fact that it can be valid, for example, the middle of the svg path, large base64 image or just a long text.

So in this pr I suggest you a solution to work compatible with the new react streaming api.

@ignatiqq ignatiqq marked this pull request as draft November 14, 2023 13:30
@quantizor
Copy link
Contributor

quantizor commented Apr 30, 2024

Thank you for working on this, I have no practical project for streaming testing at this point but I'd be happy to post a test release under a tag for people to try and report back

@quantizor
Copy link
Contributor

Published under styled-components@react-18-streaming-prototype for those interested in testing

@ignatiqq
Copy link
Author

ignatiqq commented May 1, 2024

Oh, i really forgot about this pr. It's really unstable now.
But if you don't mind i can continue work on it in the next month. Now i'm really busy.
The main problem now is that it will trigger hydration issue without any scripts which should move styles outside the root react component. We should somehow give users way to control how should it work.

@quantizor
Copy link
Contributor

Of course! That's why it's a test build 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants