React < 16.3 support (WIP) #1113
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import React, { Component } from 'react'; | ||
|
There was a problem hiding this comment. I'd move it to |
||
| import PropTypes from 'prop-types'; | ||
|
|
||
| export const Context = React.createContext(); | ||
|
|
||
| export function Consumer(WrappedComponent) { | ||
|
There was a problem hiding this comment. I'd call it |
||
| const componentName = WrappedComponent.name.replace(/Renderer$/, ''); | ||
| return class extends Component { | ||
| static displayName = `Consumer(${componentName})`; | ||
| state = {}; | ||
| render() { | ||
| return ( | ||
| <Context.Consumer> | ||
| {context => { | ||
| if (!context) { | ||
| throw new Error(`Consumer cannot be rendered outside the Provider component`); | ||
| } | ||
| return <WrappedComponent {...context} {...this.props} />; | ||
| }} | ||
| </Context.Consumer> | ||
| ); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| export function Provider(props) { | ||
| const { children, ...rest } = props; | ||
| const ui = typeof children === 'function' ? children(this.state) : children; | ||
|
There was a problem hiding this comment. It will be removed! |
||
|
|
||
| return <Context.Provider value={{ ...rest }}>{ui}</Context.Provider>; | ||
| } | ||
|
|
||
| Provider.propTypes = { | ||
| children: PropTypes.any, | ||
| codeRevision: PropTypes.number.isRequired, | ||
|
There was a problem hiding this comment. You're not using some of these props. There was a problem hiding this comment. I have copied from this childContextTypes because they are used in several components |
||
| config: PropTypes.object.isRequired, | ||
| slots: PropTypes.object.isRequired, | ||
| displayMode: PropTypes.string, | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I had problems in Windows, it relates with this issue:
prettier/prettier#4086 (comment)
And here explains that
https://prettier.io/docs/en/cli.html
Maybe it should be other PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️
We should change it here, otherwise the script will overwrite the command eventually:
https://github.com/sapegin/mrm-tasks/blob/master/packages/mrm-task-prettier/index.js#L82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing project @sapegin!