Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken assetsDir due to updated copy-webpack-plugin #1690

Merged
merged 3 commits into from Sep 8, 2020
Merged

Fix broken assetsDir due to updated copy-webpack-plugin #1690

merged 3 commits into from Sep 8, 2020

Commits on Sep 8, 2020

  1. fix: broken assetsDir during build 

    Because copy-webpack-pluign was updated, the assetsDir was broken.
We need to update the config being passed to the plugin to make it
work again. Update the plugin to latest version 6.1.0 and update
the config and tests to make it work.
    @swashata
    swashata committed Sep 8, 2020
    Copy the full SHA
    239a54d View commit details
    Browse the repository at this point in the history

  2. fix: failing tests in highlightcode spec 

    Error message was updated in code, but not in tests.
    @swashata
    swashata committed Sep 8, 2020
    Copy the full SHA
    f45dfb6 View commit details
    Browse the repository at this point in the history

  3. chore: add fixme label to new copy-webpack-plugin config 

    Since we don't have the latest types right now
we have to cast to any. Once the types are released
we can remove it.

Co-authored-by: Artem Sapegin <artem@sapegin.ru>
    @swashata @sapegin
    swashata and sapegin committed Sep 8, 2020
    Copy the full SHA
    bc47d4d View commit details
    Browse the repository at this point in the history