Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions CI. #50

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Switch to GitHub Actions CI. #50

merged 2 commits into from
Oct 8, 2019

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 19, 2019

This is just a basic setup, I haven't backported the branch limitations.

@kristerkari: first you will need to enable GH Actions: https://github.com/features/actions

EDIT: it seems there's a bug and on Windows they use Node.js 8.10.0 which doesn't have npm ci command. actions/setup-node#27

@XhmikosR XhmikosR marked this pull request as ready for review September 21, 2019 09:41
@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 1, 2019

@kristerkari
Copy link
Collaborator

I haven't used Github's CI before, so I think that I need to look into it a bit before switching to use it.

If it has the same features as the other CI systems, then it's ok for me.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 1, 2019

It's actually better IMO so far. You can test fast, cross-platform, and without another 3rd-party service.

It does lack some features like caching, but those will be fixed eventually.

@ntwb
Copy link

ntwb commented Oct 1, 2019

stylelint switched a couple of weeks ago, pretty happy with it

You can see the final PR we merged adding them here:

stylelint/stylelint#4285

@XhmikosR XhmikosR mentioned this pull request Oct 6, 2019
@kristerkari kristerkari merged commit 207bda3 into stylelint-scss:master Oct 8, 2019
@XhmikosR XhmikosR deleted the gh-actions branch October 8, 2019 09:23
@kristerkari
Copy link
Collaborator

Thanks for taking the time to do the changes!

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2019

@kristerkari you haven't registered for Actions yet :/

@kristerkari
Copy link
Collaborator

I just did a few minutes ago

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2019

Weird, I don't see them enabled yet...

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2019

Either way, you should remove Travis and AppVeyor from apps/integrations/hooks when Actions is enabled.

@kristerkari
Copy link
Collaborator

I'm currently removing AppVeoyr and Travis

@kristerkari
Copy link
Collaborator

Weird, I don't see them enabled yet...

It seems that there is some kind of a waiting list since it's a Beta feature. I guess we'll just have to wait a bit for it to be enabled.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 8, 2019

No worries, you can revert this and make a new PR to merge when it's enabled.

@kristerkari
Copy link
Collaborator

Let's see how long it takes, if it's quick, then I don't think that there is any need to revert the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants