Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unit-whitelist with unit-allowed-list in README example #70

Merged
merged 1 commit into from Aug 31, 2020
Merged

Replace unit-whitelist with unit-allowed-list in README example #70

merged 1 commit into from Aug 31, 2020

Conversation

mattxwang
Copy link
Member

@mattxwang mattxwang commented Jul 5, 2020 •
edited

This PR amends the README documentation with the new rule names and links involving *-allowed-list/*-disallowed-list, as discussed in stylelint/stylelint#4844 and stylelint/stylelint#4845. In this case, that just involves unit-whitelist -> unit-allowed-list in one example.

This PR is blocked by:

  • that change being released
  • the stylelint.io website being updated

Which issue, if any, is this issue related to?

Closes #69.

Is there anything in the PR that needs further explanation?

Nope!

@mattxwang mattxwang added the pr: blocked is blocked by another issue or pr label Jul 5, 2020
jeddy3
jeddy3 approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeddy3 jeddy3 merged commit c2308a1 into master Aug 31, 2020
@jeddy3 jeddy3 deleted the replace-whitelist-allowed-list branch August 31, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
pr: blocked is blocked by another issue or pr
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace unit-whitelist with unit-allowed-list
2 participants
@mattxwang @jeddy3