Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace *-whitelist/*-blacklist rules with *-allowed-list/*-disallowed-list rules #151

Merged
merged 1 commit into from Aug 31, 2020

Conversation

mattxwang
Copy link
Member

This PR amends the README documentation with the new rule names and links involving *-allowed-list/*-disallowed-list, as discussed in stylelint/stylelint#4844 and stylelint/stylelint#4845.

This PR is blocked by:

  • that change being released
  • the stylelint.io website being updated

Which issue, if any, is this issue related to?

Closes #150.

Is there anything in the PR that needs further explanation?

I just did a simple search and replace, and that seems reasonable based off of the diff. Let me know if there's anything else I should change!

@mattxwang mattxwang added the pr: blocked is blocked by another issue or pr label Jul 3, 2020
@mattxwang
Copy link
Member Author

Let me know if this is the way we want to approach this - if so, I can submit a similar PR to our other config.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM. As you said, let's merge once those two criteria are met.

@jeddy3 jeddy3 merged commit f650092 into master Aug 31, 2020
@jeddy3 jeddy3 deleted the adjust--list-rules branch August 31, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: blocked is blocked by another issue or pr
Development

Successfully merging this pull request may close these issues.

Replace *-whitelist/*-blacklist rules with *-allowed-list/*-disallowed-list rules
2 participants