Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lightness-notation #306

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Add lightness-notation #306

merged 3 commits into from
Dec 25, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Dec 20, 2023

Which issue, if any, is this issue related to?

Ref stylelint/stylelint#7366

Is there anything in the PR that needs further explanation?

Stylelint 16.1.0 will add a new rule lightness-notation.

I believe specifying the "percentage" primary option makes sense since percentage lightness values are often used. For example, see the MDN document about oklch().

For example:

$ echo 'a { color: oklch(0.85 0.17 88deg) }' | npx stylelint -c index.js

<input css 1A2DBa>
 1:18  ✖  Expected "0.85" to be "85%"  lightness-notation

1 problem (1 error, 0 warnings)

Stylelint 16.1.0 will add a new rule `lightness-notation`.
package.json Outdated Show resolved Hide resolved
@ybiquitous ybiquitous marked this pull request as ready for review December 20, 2023 16:04
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge as part of the release process.

@ybiquitous ybiquitous merged commit ef48124 into main Dec 25, 2023
6 checks passed
@ybiquitous ybiquitous deleted the lightness-notation branch December 25, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants