Migrate all rules to ESM again (#7262)

1. Run `node scripts/rewrite-rules-to-esm.mjs`
2. Manually fix lint and test failures

Note that `scripts/rewrite-rules-to-esm.mjs` is removed.

lib/__tests__/disableRanges-integration.test.mjs

@@ -1,7 +1,7 @@
-import blockNoEmpty from '../rules/block-no-empty/index.js';
-import noDuplicateSelectors from '../rules/no-duplicate-selectors/index.js';
-import numberMaxPrecision from '../rules/number-max-precision/index.js';
-import stringNoNewline from '../rules/string-no-newline/index.js';
+import blockNoEmpty from '../rules/block-no-empty/index.mjs';
+import noDuplicateSelectors from '../rules/no-duplicate-selectors/index.mjs';
+import numberMaxPrecision from '../rules/number-max-precision/index.mjs';
+import stringNoNewline from '../rules/string-no-newline/index.mjs';
 
 // disabling all rules
 testRule({

lib/__tests__/standalone-deprecations.test.mjs

@@ -4,10 +4,10 @@ import standalone from '../standalone.mjs';
 
 import { jest } from '@jest/globals';
 
-jest.mock('../rules/block-no-empty');
+jest.mock('../rules/block-no-empty/index.cjs');
 
 const require = createRequire(import.meta.url);
-const blockNoEmpty = require('../rules/block-no-empty/index.js');
+const blockNoEmpty = require('../rules/block-no-empty/index.cjs');
 
 const configBlockNoEmpty = readJSONFile(
 	new URL('./fixtures/config-block-no-empty.json', import.meta.url),

lib/__tests__/standalone-parseErrors.test.mjs

@@ -9,10 +9,10 @@ const configBlockNoEmpty = readJSONFile(
 	new URL('./fixtures/config-block-no-empty.json', import.meta.url),
 );
 
-jest.mock('../rules/block-no-empty');
+jest.mock('../rules/block-no-empty/index.cjs');
 
 const require = createRequire(import.meta.url);
-const blockNoEmpty = require('../rules/block-no-empty/index.js');
+const blockNoEmpty = require('../rules/block-no-empty/index.cjs');
 
 blockNoEmpty.mockImplementation(() => {
 	return (root, result) => {

lib/__tests__/standalone-quiet-deprecation-warnings.test.mjs

@@ -3,10 +3,10 @@ import { jest } from '@jest/globals';
 import report from '../utils/report.mjs';
 import standalone from '../standalone.mjs';
 
-jest.mock('../rules/block-no-empty');
+jest.mock('../rules/block-no-empty/index.cjs');
 
 const require = createRequire(import.meta.url);
-const deprecatedRule = require('../rules/block-no-empty/index.js');
+const deprecatedRule = require('../rules/block-no-empty/index.cjs');
 
 deprecatedRule.mockImplementation(() => {
 	return (root, result) => {

lib/rules/annotation-no-unknown/__tests__/index.mjs

@@ -1,4 +1,4 @@
-import rule from '../index.js';
+import rule from '../index.mjs';
 const { messages, ruleName } = rule;
 
 testRule({

lib/rules/annotation-no-unknown/index.js → lib/rules/annotation-no-unknown/index.cjs

@@ -1,8 +1,7 @@
 'use strict';
 
 const valueParser = require('postcss-value-parser');
-
-const { isRegExp, isString } = require('../../utils/validateTypes.cjs');
+const validateTypes = require('../../utils/validateTypes.cjs');
 const getDeclarationValue = require('../../utils/getDeclarationValue.cjs');
 const isStandardSyntaxValue = require('../../utils/isStandardSyntaxValue.cjs');
 const optionsMatches = require('../../utils/optionsMatches.cjs');
@@ -30,7 +29,7 @@ const rule = (primary, secondaryOptions) => {
 			{
 				actual: secondaryOptions,
 				possible: {
-					ignoreAnnotations: [isString, isRegExp],
+					ignoreAnnotations: [validateTypes.isString, validateTypes.isRegExp],
 				},
 				optional: true,
 			},
@@ -87,4 +86,5 @@ const rule = (primary, secondaryOptions) => {
 rule.ruleName = ruleName;
 rule.messages = messages;
 rule.meta = meta;
+
 module.exports = rule;

lib/rules/annotation-no-unknown/index.mjs

@@ -0,0 +1,88 @@
+import valueParser from 'postcss-value-parser';
+
+import { isRegExp, isString } from '../../utils/validateTypes.mjs';
+import getDeclarationValue from '../../utils/getDeclarationValue.mjs';
+import isStandardSyntaxValue from '../../utils/isStandardSyntaxValue.mjs';
+import optionsMatches from '../../utils/optionsMatches.mjs';
+import report from '../../utils/report.mjs';
+import ruleMessages from '../../utils/ruleMessages.mjs';
+import validateOptions from '../../utils/validateOptions.mjs';
+
+const ruleName = 'annotation-no-unknown';
+
+const messages = ruleMessages(ruleName, {
+	rejected: (annotation) => `Unexpected unknown annotation "${annotation}"`,
+});
+
+const meta = {
+	url: 'https://stylelint.io/user-guide/rules/annotation-no-unknown',
+};
+
+/** @type {import('stylelint').Rule} */
+const rule = (primary, secondaryOptions) => {
+	return (root, result) => {
+		const validOptions = validateOptions(
+			result,
+			ruleName,
+			{ actual: primary },
+			{
+				actual: secondaryOptions,
+				possible: {
+					ignoreAnnotations: [isString, isRegExp],
+				},
+				optional: true,
+			},
+		);
+
+		if (!validOptions) {
+			return;
+		}
+
+		root.walkDecls(checkStatement);
+
+		/**
+		 * @param {import('postcss').Declaration} decl
+		 */
+		function checkStatement(decl) {
+			if (!isStandardSyntaxValue(decl.value)) return;
+
+			if (decl.important) return;
+
+			if (!decl.value.includes('!')) return;
+
+			const parsedValue = valueParser(getDeclarationValue(decl));
+
+			parsedValue.walk((node) => {
+				if (!isAnnotation(node)) return;
+
+				const value = node.value;
+				const tokenValue = value.slice(1);
+
+				if (optionsMatches(secondaryOptions, 'ignoreAnnotations', tokenValue)) {
+					return;
+				}
+
+				report({
+					message: messages.rejected,
+					messageArgs: [value],
+					node: decl,
+					result,
+					ruleName,
+					word: value,
+				});
+			});
+		}
+
+		/**
+		 * @param {valueParser.Node} node
+		 */
+		function isAnnotation(node) {
+			return node.type === 'word' && node.value.startsWith('!');
+		}
+	};
+};
+
+rule.ruleName = ruleName;
+rule.messages = messages;
+rule.meta = meta;
+export default rule;

lib/rules/at-rule-allowed-list/__tests__/index.mjs

@@ -1,4 +1,4 @@
-import rule from '../index.js';
+import rule from '../index.mjs';
 const { messages, ruleName } = rule;
 
 testRule({

lib/rules/at-rule-allowed-list/index.js → lib/rules/at-rule-allowed-list/index.cjs

@@ -1,7 +1,7 @@
 'use strict';
 
 const isStandardSyntaxAtRule = require('../../utils/isStandardSyntaxAtRule.cjs');
-const { isString } = require('../../utils/validateTypes.cjs');
+const validateTypes = require('../../utils/validateTypes.cjs');
 const report = require('../../utils/report.cjs');
 const ruleMessages = require('../../utils/ruleMessages.cjs');
 const validateOptions = require('../../utils/validateOptions.cjs');
@@ -22,7 +22,7 @@ const rule = (primary) => {
 	return (root, result) => {
 		const validOptions = validateOptions(result, ruleName, {
 			actual: primary,
-			possible: [isString],
+			possible: [validateTypes.isString],
 		});
 
 		if (!validOptions) {
@@ -59,4 +59,5 @@ rule.primaryOptionArray = true;
 rule.ruleName = ruleName;
 rule.messages = messages;
 rule.meta = meta;
+
 module.exports = rule;

lib/rules/at-rule-allowed-list/index.mjs

@@ -0,0 +1,60 @@
+import isStandardSyntaxAtRule from '../../utils/isStandardSyntaxAtRule.mjs';
+import { isString } from '../../utils/validateTypes.mjs';
+import report from '../../utils/report.mjs';
+import ruleMessages from '../../utils/ruleMessages.mjs';
+import validateOptions from '../../utils/validateOptions.mjs';
+import vendor from '../../utils/vendor.mjs';
+
+const ruleName = 'at-rule-allowed-list';
+
+const messages = ruleMessages(ruleName, {
+	rejected: (name) => `Unexpected at-rule "${name}"`,
+});
+
+const meta = {
+	url: 'https://stylelint.io/user-guide/rules/at-rule-allowed-list',
+};
+
+/** @type {import('stylelint').Rule<string | string[]>} */
+const rule = (primary) => {
+	return (root, result) => {
+		const validOptions = validateOptions(result, ruleName, {
+			actual: primary,
+			possible: [isString],
+		});
+
+		if (!validOptions) {
+			return;
+		}
+
+		const primaryValues = [primary].flat();
+
+		root.walkAtRules((atRule) => {
+			const name = atRule.name;
+
+			if (!isStandardSyntaxAtRule(atRule)) {
+				return;
+			}
+
+			if (primaryValues.includes(vendor.unprefixed(name).toLowerCase())) {
+				return;
+			}
+
+			report({
+				message: messages.rejected,
+				messageArgs: [name],
+				node: atRule,
+				result,
+				ruleName,
+				word: `@${name}`,
+			});
+		});
+	};
+};
+
+rule.primaryOptionArray = true;
+
+rule.ruleName = ruleName;
+rule.messages = messages;
+rule.meta = meta;
+export default rule;

lib/rules/at-rule-disallowed-list/__tests__/index.mjs

@@ -1,4 +1,4 @@
-import rule from '../index.js';
+import rule from '../index.mjs';
 const { messages, ruleName } = rule;
 
 testRule({

lib/rules/at-rule-disallowed-list/index.js → lib/rules/at-rule-disallowed-list/index.cjs

@@ -1,7 +1,7 @@
 'use strict';
 
 const isStandardSyntaxAtRule = require('../../utils/isStandardSyntaxAtRule.cjs');
-const { isString } = require('../../utils/validateTypes.cjs');
+const validateTypes = require('../../utils/validateTypes.cjs');
 const report = require('../../utils/report.cjs');
 const ruleMessages = require('../../utils/ruleMessages.cjs');
 const validateOptions = require('../../utils/validateOptions.cjs');
@@ -22,7 +22,7 @@ const rule = (primary) => {
 	return (root, result) => {
 		const validOptions = validateOptions(result, ruleName, {
 			actual: primary,
-			possible: [isString],
+			possible: [validateTypes.isString],
 		});
 
 		if (!validOptions) {
@@ -59,4 +59,5 @@ rule.primaryOptionArray = true;
 rule.ruleName = ruleName;
 rule.messages = messages;
 rule.meta = meta;
+
 module.exports = rule;

lib/rules/at-rule-disallowed-list/index.mjs

@@ -0,0 +1,60 @@
+import isStandardSyntaxAtRule from '../../utils/isStandardSyntaxAtRule.mjs';
+import { isString } from '../../utils/validateTypes.mjs';
+import report from '../../utils/report.mjs';
+import ruleMessages from '../../utils/ruleMessages.mjs';
+import validateOptions from '../../utils/validateOptions.mjs';
+import vendor from '../../utils/vendor.mjs';
+
+const ruleName = 'at-rule-disallowed-list';
+
+const messages = ruleMessages(ruleName, {
+	rejected: (name) => `Unexpected at-rule "${name}"`,
+});
+
+const meta = {
+	url: 'https://stylelint.io/user-guide/rules/at-rule-disallowed-list',
+};
+
+/** @type {import('stylelint').Rule<string | string[]>} */
+const rule = (primary) => {
+	return (root, result) => {
+		const validOptions = validateOptions(result, ruleName, {
+			actual: primary,
+			possible: [isString],
+		});
+
+		if (!validOptions) {
+			return;
+		}
+
+		const primaryValues = [primary].flat();
+
+		root.walkAtRules((atRule) => {
+			const name = atRule.name;
+
+			if (!isStandardSyntaxAtRule(atRule)) {
+				return;
+			}
+
+			if (!primaryValues.includes(vendor.unprefixed(name).toLowerCase())) {
+				return;
+			}
+
+			report({
+				message: messages.rejected,
+				messageArgs: [name],
+				node: atRule,
+				result,
+				ruleName,
+				word: `@${atRule.name}`,
+			});
+		});
+	};
+};
+
+rule.primaryOptionArray = true;
+
+rule.ruleName = ruleName;
+rule.messages = messages;
+rule.meta = meta;
+export default rule;

lib/rules/at-rule-empty-line-before/__tests__/index.mjs

@@ -1,7 +1,7 @@
 import { stripIndent } from 'common-tags';
 
 import mergeTestDescriptions from '../../../testUtils/mergeTestDescriptions.mjs';
-import rule from '../index.js';
+import rule from '../index.mjs';
 const { messages, ruleName } = rule;
 
 const sharedAlwaysTests = {

lib/rules/at-rule-empty-line-before/index.js → lib/rules/at-rule-empty-line-before/index.cjs

@@ -4,13 +4,13 @@ const addEmptyLineBefore = require('../../utils/addEmptyLineBefore.cjs');
 const getPreviousNonSharedLineCommentNode = require('../../utils/getPreviousNonSharedLineCommentNode.cjs');
 const hasEmptyLine = require('../../utils/hasEmptyLine.cjs');
 const isAfterComment = require('../../utils/isAfterComment.cjs');
-const { isAtRule } = require('../../utils/typeGuards.cjs');
+const typeGuards = require('../../utils/typeGuards.cjs');
 const isBlocklessAtRuleAfterBlocklessAtRule = require('../../utils/isBlocklessAtRuleAfterBlocklessAtRule.cjs');
 const isBlocklessAtRuleAfterSameNameBlocklessAtRule = require('../../utils/isBlocklessAtRuleAfterSameNameBlocklessAtRule.cjs');
 const isFirstNested = require('../../utils/isFirstNested.cjs');
 const isFirstNodeOfRoot = require('../../utils/isFirstNodeOfRoot.cjs');
 const isStandardSyntaxAtRule = require('../../utils/isStandardSyntaxAtRule.cjs');
-const { isString } = require('../../utils/validateTypes.cjs');
+const validateTypes = require('../../utils/validateTypes.cjs');
 const optionsMatches = require('../../utils/optionsMatches.cjs');
 const removeEmptyLinesBefore = require('../../utils/removeEmptyLinesBefore.cjs');
 const report = require('../../utils/report.cjs');
@@ -56,7 +56,7 @@ const rule = (primary, secondaryOptions, context) => {
 						'blockless-after-same-name-blockless',
 						'blockless-after-blockless',
 					],
-					ignoreAtRules: [isString],
+					ignoreAtRules: [validateTypes.isString],
 				},
 				optional: true,
 			},
@@ -164,10 +164,11 @@ const rule = (primary, secondaryOptions, context) => {
 function isAtRuleAfterSameNameAtRule(atRule) {
 	const previousNode = getPreviousNonSharedLineCommentNode(atRule);
 
-	return previousNode && isAtRule(previousNode) && previousNode.name === atRule.name;
+	return previousNode && typeGuards.isAtRule(previousNode) && previousNode.name === atRule.name;
 }
 
 rule.ruleName = ruleName;
 rule.messages = messages;
 rule.meta = meta;
+
 module.exports = rule;