Refactor to use return instead of break in loop

stylelint · Apr 27, 2024 · 101003d · 101003d
1 parent 7ab186d
commit 101003d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/lib/rules/shorthand-property-no-redundant-values/index.cjs b/lib/rules/shorthand-property-no-redundant-values/index.cjs
@@ -132,12 +132,9 @@ const rule = (primary, _secondaryOptions, context) => {
 			/** @type {string[]} */
 			const valuesToShorthand = [];
 
-			let shouldIgnore = false;
-
 			for (const valueNode of valueParser(value).nodes) {
 				if (typeGuards.isValueDiv(valueNode)) {
-					shouldIgnore = true;
-					break;
+					return;
 				}
 
 				// `var()` should be ignored. E.g.
@@ -146,17 +143,14 @@ const rule = (primary, _secondaryOptions, context) => {
 				//   padding: 0 var(--padding) 0;
 				//
 				if (typeGuards.isValueFunction(valueNode) && valueNode.value.toLowerCase() === 'var') {
-					shouldIgnore = true;
-					break;
+					return;
 				}
 
 				if (typeGuards.isValueWord(valueNode) || typeGuards.isValueFunction(valueNode)) {
 					valuesToShorthand.push(valueParser.stringify(valueNode));
 				}
 			}
 
-			if (shouldIgnore) return;
-
 			if (valuesToShorthand.length <= 1 || valuesToShorthand.length > 4) {
 				return;
 			}

diff --git a/lib/rules/shorthand-property-no-redundant-values/index.mjs b/lib/rules/shorthand-property-no-redundant-values/index.mjs
@@ -130,12 +130,9 @@ const rule = (primary, _secondaryOptions, context) => {
 			/** @type {string[]} */
 			const valuesToShorthand = [];
 
-			let shouldIgnore = false;
-
 			for (const valueNode of valueParser(value).nodes) {
 				if (isValueDiv(valueNode)) {
-					shouldIgnore = true;
-					break;
+					return;
 				}
 
 				// `var()` should be ignored. E.g.
@@ -144,17 +141,14 @@ const rule = (primary, _secondaryOptions, context) => {
 				//   padding: 0 var(--padding) 0;
 				//
 				if (isValueFunction(valueNode) && valueNode.value.toLowerCase() === 'var') {
-					shouldIgnore = true;
-					break;
+					return;
 				}
 
 				if (isValueWord(valueNode) || isValueFunction(valueNode)) {
 					valuesToShorthand.push(valueParser.stringify(valueNode));
 				}
 			}
 
-			if (shouldIgnore) return;
-
 			if (valuesToShorthand.length <= 1 || valuesToShorthand.length > 4) {
 				return;
 			}