Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed "hasMagic" check before escaping paths. (#4931)
* Removed "hasMagic" check before escaping paths. Globby's "hasMagic" function, which is meant to detect if a path contains globbing characters, notably does not detect paths that contain matched parentheses, unless those matched parentheses have extra globbing characters attached to them. This is a problem because globby requires matches parentheses to be escaped, if they are part of the literal path. This changes the part of the code that escapes paths that literally exist to not check "hasMagic" first, to get around that oversight. * Add test * Update comment Co-authored-by: m-allanson <michael.allanson@gmail.com>
- Loading branch information
1 parent
89a530b
commit 1dfd78b
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
a {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters