Add @types/postcss-less (#4920)

This is a part of #4496 and improves type-checking about LESS. (fixing `// @ts-ignore`) https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/postcss-less
stylelint · Sep 13, 2020 · 528c06d · 528c06d
1 parent 6e1ab1c
commit 528c06d
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 15 deletions.
diff --git a/lib/utils/isLessVariable.js b/lib/utils/isLessVariable.js
@@ -3,10 +3,12 @@
 const hasBlock = require('./hasBlock');
 
 /**
- * @param {import('postcss').AtRule} atRule
+ * @param {import('postcss').AtRule | import('postcss-less').AtRule} atRule
  * @returns {boolean}
  */
 module.exports = function (atRule) {
-	// @ts-ignore TODO TYPES LESS property variable does not exists in types
-	return (atRule.type === 'atrule' && atRule.variable && !hasBlock(atRule)) || false;
+	return (
+		(atRule.type === 'atrule' && 'variable' in atRule && atRule.variable && !hasBlock(atRule)) ||
+		false
+	);
 };
diff --git a/lib/utils/isStandardSyntaxAtRule.js b/lib/utils/isStandardSyntaxAtRule.js
@@ -3,7 +3,7 @@
 /**
  * Check whether a at-rule is standard
  *
- * @param {import('postcss').AtRule} atRule postcss at-rule node
+ * @param {import('postcss').AtRule | import('postcss-less').AtRule} atRule postcss at-rule node
  * @return {boolean} If `true`, the declaration is standard
  */
 module.exports = function (atRule) {
@@ -13,15 +13,13 @@ module.exports = function (atRule) {
 	}
 
 	// Ignore Less mixins
-	// @ts-ignore TODO TYPES Is this property really exists?
-	if (atRule.mixin) {
+	if ('mixin' in atRule && atRule.mixin) {
 		return false;
 	}
 
 	// Ignore Less detached ruleset `@detached-ruleset: { background: red; }; .top { @detached-ruleset(); }`
 	if (
-		// @ts-ignore TODO TYPES Is this property really exists?
-		atRule.variable ||
+		('variable' in atRule && atRule.variable) ||
 		(!atRule.nodes && atRule.raws.afterName === '' && atRule.params[0] === '(')
 	) {
 		return false;

diff --git a/lib/utils/isStandardSyntaxDeclaration.js b/lib/utils/isStandardSyntaxDeclaration.js
@@ -13,7 +13,7 @@ function isStandardSyntaxLang(lang) {
 /**
  * Check whether a declaration is standard
  *
- * @param {import('postcss').Declaration} decl
+ * @param {import('postcss').Declaration | import('postcss-less').Declaration} decl
  */
 module.exports = function (decl) {
 	const prop = decl.prop;
@@ -53,8 +53,7 @@ module.exports = function (decl) {
 	}
 
 	// Less &:extend
-	// @ts-ignore TODO TYPES extend does not exists
-	if (decl.extend) {
+	if ('extend' in decl && decl.extend) {
 		return false;
 	}
 

diff --git a/lib/utils/isStandardSyntaxRule.js b/lib/utils/isStandardSyntaxRule.js
@@ -7,7 +7,7 @@ const isStandardSyntaxSelector = require('../utils/isStandardSyntaxSelector');
 /**
  * Check whether a Node is a standard rule
  *
- * @param {import('postcss').Rule} rule
+ * @param {import('postcss').Rule | import('postcss-less').Rule} rule
  * @returns {boolean}
  */
 module.exports = function (rule) {
@@ -39,8 +39,7 @@ module.exports = function (rule) {
 	}
 
 	// Ignore Less &:extend rule
-	// @ts-ignore TODO TYPES support LESS and SASS types somehow
-	if (rule.extend) {
+	if ('extend' in rule && rule.extend) {
 		return false;
 	}
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -171,6 +171,7 @@
     "@types/imurmurhash": "^0.1.1",
     "@types/lodash": "^4.14.161",
     "@types/micromatch": "^4.0.1",
+    "@types/postcss-less": "^3.1.1",
     "@types/postcss-safe-parser": "^4.0.0",
     "@types/style-search": "^0.1.1",
     "@types/svg-tags": "^1.0.0",

diff --git a/types/global.d.ts b/types/global.d.ts
@@ -2,6 +2,5 @@ declare module '@stylelint/postcss-css-in-js';
 declare module '@stylelint/postcss-markdown';
 declare module 'import-lazy';
 declare module 'postcss-html';
-declare module 'postcss-less';
 declare module 'postcss-sass';
 declare module 'sugarss';