Skip to content

Commit

Permalink
Prepare v15 on CI (#6424)
Browse files Browse the repository at this point in the history
- Add `v15` branch to the triggers
- Drop Node.js 12 from the matrix
- Collect test coverage on Node.js 18 (comming soon LTS)
  • Loading branch information
ybiquitous committed Nov 8, 2022
1 parent 2724aa4 commit e5fc85b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
1 change: 1 addition & 0 deletions .github/workflows/code-scanning.yml
Expand Up @@ -5,6 +5,7 @@ on:
branches:
- main
- '!dependabot/**'
- v15 # TODO: We can remove this line after shipping v15.
pull_request:
# The branches below must be a subset of the branches above
branches:
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/releasing.yml
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- main
- v15 # TODO: We can remove this line after shipping v15.

permissions:
contents: write
Expand Down Expand Up @@ -39,8 +40,8 @@ jobs:
- name: Create release pull request
uses: changesets/action@v1
with:
commit: Prepare release
title: Prepare release
commit: Prepare release 15.0.0
title: Prepare release 15.0.0
# this expects you to have a npm script called version that runs some logic and then calls `changeset version`.
# We're also restoring `package.json` because we're using `np` for publishing
version: npm run version
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/testing.yml
Expand Up @@ -5,6 +5,7 @@ on:
branches:
- main
- 'dependabot/**'
- v15 # TODO: We can remove this line after shipping v15.
pull_request:
branches:
- '**'
Expand All @@ -26,7 +27,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [12, 14, 16, 18]
node: [14, 16, 18]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
Expand All @@ -46,14 +47,14 @@ jobs:

- name: Test
run: npm run jest
if: "!(startsWith(matrix.os, 'ubuntu') && matrix.node == 16)"
if: "!(startsWith(matrix.os, 'ubuntu') && matrix.node == 18)"

- name: Test with coverage
run: npm run jest -- --coverage
if: startsWith(matrix.os, 'ubuntu') && matrix.node == 16
if: startsWith(matrix.os, 'ubuntu') && matrix.node == 18

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
if: startsWith(matrix.os, 'ubuntu') && matrix.node == 16
if: startsWith(matrix.os, 'ubuntu') && matrix.node == 18
with:
files: ./.coverage/lcov.info

0 comments on commit e5fc85b

Please sign in to comment.