Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jest:detectleaks npm script for Jest memory leak testing. #3123

Merged
merged 2 commits into from Jan 12, 2018

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Jan 12, 2018

Follow up to #3069/ #3121

@ntwb
Copy link
Member Author

ntwb commented Jan 12, 2018

I've created #3124 to list, and seek help in fixing the current 17 tests that fail

@hudochenkov
Copy link
Member

What weak for? Is it peer or optional dependency of Jest?

@ntwb
Copy link
Member Author

ntwb commented Jan 12, 2018

My bad, I should have added a note about weak, Jest Leak Detector requires weak:
https://github.com/facebook/jest/blob/master/packages/jest-leak-detector/package.json#L14

@hudochenkov
Copy link
Member

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hudochenkov hudochenkov merged commit 4e7658a into master Jan 12, 2018
@hudochenkov hudochenkov deleted the add/weak branch January 12, 2018 09:32
@ntwb
Copy link
Member Author

ntwb commented Jan 12, 2018

I think it's due to the mono repo Facebook use:
• ~35 npm modules in a single repo https://github.com/facebook/jest/tree/master/packages
• Lerna is what's used to manage this repo setup https://lernajs.io/ - "A tool for managing JavaScript projects with multiple packages."

@hudochenkov
Copy link
Member

It shouldn't be because of Lerna. I use it at work and any package could have whatever dependencies it wants.

@SimenB
Copy link

SimenB commented Feb 18, 2018

It's because of jestjs/jest#5169, fwiw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants