Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks in tests #3249

Merged
merged 1 commit into from Apr 3, 2018
Merged

Fix memory leaks in tests #3249

merged 1 commit into from Apr 3, 2018

Conversation

hudochenkov
Copy link
Member

Which issue, if any, is this issue related to?

#3124

Is there anything in the PR that needs further explanation?

description should be string only.

To verify it fixes leaks, also, run following commands for master and for this PR:

$ npm run jest:detectleaks -- lib/rules/declaration-property-value-blacklist/__tests__/index.js
$ npm run jest:detectleaks -- lib/rules/function-url-quotes/__tests__/index.js

@hudochenkov hudochenkov mentioned this pull request Apr 2, 2018
Closed
jeddy3
jeddy3 approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, nice sleuthing!

@hudochenkov hudochenkov merged commit f45dd0b into master Apr 3, 2018
@hudochenkov hudochenkov deleted the fix-memory-leaks branch April 3, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hudochenkov @jeddy3 @alexander-akait