-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add types to standalone.js, cli.js, index.js, required utils #4381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
🎉 closes #4245 🥁
I would argue with this :)
There are at least two things to do:
- Add types for https://github.com/stylelint/stylelint/tree/master/lib/utils
- Remove Flow
we can create issues for this things =) |
Issue states “Replace Flow with TypeScript JSDoc” which is not done yet 🤷♂So let's not close it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 💯
🎉 related to #4245 🥁, all TODOs we can resolve in separate PRs
Nothing