Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types to standalone.js, cli.js, index.js, required utils #4381

Merged
merged 9 commits into from
Oct 27, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Oct 25, 2019

Which issue, if any, is this issue related to?

🎉 related to #4245 🥁, all TODOs we can resolve in separate PRs

Is there anything in the PR that needs further explanation?

Nothing

@vankop vankop changed the title add types to standalone, cli, required utils add types to standalone.js, cli.js, index.js, required utils Oct 25, 2019
@github-actions
Copy link
Contributor

Coverage Status

Coverage increased (+0.0003%) to 96.513% when pulling 3802b99 on types-3 into 3893e33 on master.

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

🎉 closes #4245 🥁

I would argue with this :)

There are at least two things to do:

lib/cli.js Show resolved Hide resolved
lib/formatters/stringFormatter.js Outdated Show resolved Hide resolved
lib/formatters/stringFormatter.js Outdated Show resolved Hide resolved
@vankop
Copy link
Member Author

vankop commented Oct 25, 2019

I would argue with this :)

There are at least two things to do:

we can create issues for this things =)

@hudochenkov
Copy link
Member

Issue states “Replace Flow with TypeScript JSDoc” which is not done yet 🤷‍♂So let's not close it for now.

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯

@hudochenkov hudochenkov merged commit 05f94c2 into master Oct 27, 2019
@hudochenkov hudochenkov deleted the types-3 branch October 27, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants