Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move function normalizeAllRuleSettings() out to a separate module #4810

Merged
merged 1 commit into from Jun 1, 2020

Conversation

m-allanson
Copy link
Member

In a future PR this module will be required by the new browser.js module. This change has been extracted from: #4796

Which issue, if any, is this issue related to?

Related to issue #3935

Is there anything in the PR that needs further explanation?

This change is a small part of the changes in PR #4796

In a future PR this module will be required by the new `browser.js` module. This change has been extracted from: #4796
@m-allanson m-allanson changed the title Move function normalizeAllRuleSettings() out to a separate module. Move function normalizeAllRuleSettings() out to a separate module May 28, 2020
@m-allanson m-allanson mentioned this pull request May 28, 2020
14 tasks
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Refactored properly and doesn't break any tests 😄

LGTM 👍

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-allanson
Copy link
Member Author

Is this ok to merge without a changelog entry? The stylelint Maintainer Guide says:

Update the changelog directly via the GitHub website for everything except refactoring and documentation changes

@jeddy3
Copy link
Member

jeddy3 commented Jun 1, 2020

Is this ok to merge without a changelog entry?

Yes.

@m-allanson m-allanson merged commit 037338d into master Jun 1, 2020
@m-allanson m-allanson deleted the issue-3935/refactor-normalize-rule-settings branch June 1, 2020 12:56
m-allanson added a commit that referenced this pull request Jun 3, 2020
# By Mike Allanson (6) and others
# Via GitHub
* master:
  Bump @types/lodash from 4.14.152 to 4.14.154 (#4817)
  Update CHANGELOG.md
  Fix with workaround a TypeError thrown for "html" (#4797)
  Update CHANGELOG.md
  Fix false positives for variables in font-family-no-missing-generic-family-keyword (#4806)
  Update CHANGELOG.md
  Add ignoreSelectors option to block-opening-brace-space-before (#4640)
  Update CHANGELOG.md
  Fix error message percentage/number precision for alpha-value-notation (#4802)
  Create new 'createPartialStylelintResult' module (#4815)
  Move function normalizeAllRuleSettings() out to a separate module (#4810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants