Removed "hasMagic" check before escaping paths. #4923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Globby's "hasMagic" function, which is meant to detect if a path contains globbing characters, notably does not detect paths that contain matched parentheses, unless those matched parentheses have extra globbing characters attached to them. This is a problem because globby requires matches parentheses to be escaped, if they are part of the literal path. This changes the part of the code that escapes paths that literally exist to not check "hasMagic" first, to get around that oversight.
m-allanson
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Thanks @theodab, this looks good to me 👍
I've added a test for your case, and adjusted the comment.
|
Whoops. I just realized I shouldn't have made this PR from the master branch of my fork, for backwards compatibility reasons with old versions of Shaka Player. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4193
Globby's "hasMagic" function, which is meant to detect if a path
contains globbing characters, notably does not detect paths that
contain matched parentheses, unless those matched parentheses
have extra globbing characters attached to them. This is a problem
because globby requires matches parentheses to be escaped, if they
are part of the literal path.
This changes the part of the code that escapes paths that literally
exist to not check "hasMagic" first, to get around that oversight.
I'm not super knowledgeable about your codebase, so if you think this solution might break something somewhere else, feel free to request changes.