Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "hasMagic" check before escaping paths. #4931

Merged
merged 3 commits into from Sep 13, 2020

Commits on Sep 2, 2020

  1. Removed "hasMagic" check before escaping paths.

    Globby's "hasMagic" function, which is meant to detect if a path
    contains globbing characters, notably does not detect paths that
    contain matched parentheses, unless those matched parentheses
    have extra globbing characters attached to them. This is a problem
    because globby requires matches parentheses to be escaped, if they
    are part of the literal path.
    This changes the part of the code that escapes paths that literally
    exist to not check "hasMagic" first, to get around that oversight.
    theodab committed Sep 2, 2020
    Copy the full SHA
    d9bedd4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Add test

    m-allanson committed Sep 3, 2020
    Copy the full SHA
    9b9b573 View commit details
    Browse the repository at this point in the history
  2. Update comment

    m-allanson committed Sep 3, 2020
    Copy the full SHA
    941a097 View commit details
    Browse the repository at this point in the history