New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selector-disallowed-list rule #5239
Add selector-disallowed-list rule #5239
Conversation
Hello everyone. One check related to this PR fails. Should I fix it? Or it is an infrastructural issue and you will fix it on your own? |
@doing-art It was a weird issue. Tests restart helped. |
Thanks a lot for your help. I really appreciate it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doing-art Thanks for the contribution! LGTM for the code changed. 👍
I've left some comments for the document, so please confirm them.
Added a dot symbol to the `selector-disallowed-list` rule Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Added a dot symbol to the `selector-disallowed-list` rule Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Add detailed description of the paramteres of `selector-disallowed-list` rule Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doing-art Thank you for addressing my suggestions!
I've left a trivial suggestion, but your change looks good to me! 😄
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM.
Changelog entry added:
|
Closes #5116 .
No, it's self-explanatory.