Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for functions inside of math functions in length-… #5245

Merged
merged 1 commit into from Apr 20, 2021
Merged

Fix false positives for functions inside of math functions in length-… #5245

merged 1 commit into from Apr 20, 2021

Conversation

doing-art
Copy link
Contributor

…zero-no-unit rule

Which issue, if any, is this issue related to?

Fix a small diffect explained in the issue #5204

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

jeddy3
jeddy3 approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeddy3 jeddy3 merged commit 44c28c6 into stylelint:master Apr 20, 2021
@jeddy3
Copy link
Member

jeddy3 commented Apr 20, 2021

Changelog entry added:

  • Fixed: length-zero-no-unit false positives for functions inside of math functions (#5245).

@jeddy3 jeddy3 mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doing-art @jeddy3