Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate package-lock.json with npm v8.1.2 #5687

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Nov 2, 2021

@ybiquitous
Copy link
Member

@ntwb Thanks for creating this change!

The ESLint packages also should be updated?

$ npm outdated
Package                  Current  Wanted  Latest  Location                              Depended by
eslint                    7.32.0  7.32.0   8.1.0  node_modules/eslint                   stylelint
eslint-config-stylelint   14.0.0  14.0.0  15.0.0  node_modules/eslint-config-stylelint  stylelint

@ntwb
Copy link
Member Author

ntwb commented Nov 2, 2021

@ybiquitous Not required, after this PR is merged, dependabot will update the ESLlint ##5645 PR and create a new PR for eslint-config-stylelint

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. LGTM! 👌🏼

@jeddy3 jeddy3 merged commit 7c32491 into main Nov 2, 2021
@jeddy3 jeddy3 deleted the regenerate-package-lock-json-with-npm-v8 branch November 2, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants