New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false negatives for custom properties within var() in custom-property-pattern #5867
Fix false negatives for custom properties within var() in custom-property-pattern #5867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kawaguchi1102 Thank you so much for creating the pull request! And, sorry for the late response.
I've left some trivial suggestions, but this PR sounds almost good to me. 👍🏼
One more suggestion. Please rebase or merge the main branch to fix the failed CI jobs for Windows. (see #5874) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. Looking good.
Let's also reject tests for:
:root { --foo-color: #f00; } a { color: 'VAR(--boo-color)); }
:root { --foo-color: #f00; } a { color: 'var(--boo-color), var(--boo-sub-color)); }
The latter should produce two warnings, like so.
@ybiquitous @jeddy3 Thanks for the review. I have fixed them, please review again. |
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
b0bc208
to
0ef30be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kawaguchi1102 Thanks, LGTM 👍🏼
|
Closes #3655
The following problem has not been solved.
You will need to create another isuue.
#3655 (comment)