Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect column and escaped colons for selector-pseudo-element-colon-notation rule #5879

Merged
merged 3 commits into from Feb 6, 2022
Merged

Fix incorrect column and escaped colons for selector-pseudo-element-colon-notation rule #5879

merged 3 commits into from Feb 6, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

Replacing style-search with postcss-selector-parser.

ybiquitous
ybiquitous commented Feb 4, 2022
View reviewed changes
lib/utils/parseSelector.js
} catch {
result.warn('Cannot parse selector', { node, stylelintType: 'parseError' });
} catch (err) {
result.warn(`Cannot parse selector (${err})`, { node, stylelintType: 'parseError' });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] It is hard to investigate a raised error in callback unless err.

@ybiquitous ybiquitous marked this pull request as ready for review February 4, 2022 14:21
jeddy3
jeddy3 approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this bug fixed, and much cleaner code using the parser.

LGTM!

@ybiquitous
Copy link
Member Author

@jeddy3 Oh, thank you for your quick review!
Yes, the postcss-selector-parser API is so easier to use. 👍🏼

@ybiquitous
Copy link
Member Author

@jeddy3 Can we merge this PR? Or, are more approvals needed?

@jeddy3
Copy link
Member

jeddy3 commented Feb 5, 2022 •
edited

I think we can merge refactoring pull requests with one review (even if they also fix a bug and need a changelog entry). So go ahead and merge.

@ybiquitous ybiquitous merged commit fdbb420 into main Feb 6, 2022
@ybiquitous ybiquitous deleted the bugfix-selector-pseudo-element-colon-notation-rule branch February 6, 2022 05:10
@ybiquitous
Copy link
Member Author

I got it. 👍🏼 Updated changelog:

Fixed: selector-pseudo-element-colon-notation false positives for escaped colons (#5879).

kawaguchi1102 pushed a commit to kawaguchi1102/stylelint that referenced this pull request Feb 6, 2022
@ybiquitous @kawaguchi1102
Fix incorrect column and escaped colons for `selector-pseudo-element-…
1eb8fba 
…colon-notation` rule (stylelint#5879)
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for escaped colons in selector-pseudo-element-colon-notation
2 participants
@ybiquitous @jeddy3