Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parseError for double-slash comments within selector lists in no-descending-specificity #5891

Merged
merged 1 commit into from Feb 7, 2022
Merged

Fix parseError for double-slash comments within selector lists in no-descending-specificity #5891

merged 1 commit into from Feb 7, 2022

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Feb 7, 2022

Which issue, if any, is this issue related to?

Closes #5739

Is there anything in the PR that needs further explanation?

The following triggered a parse error in the selector parser.

a,
// comment2
b {}

@jeddy3
Copy link
Member Author

jeddy3 commented Feb 7, 2022

Can we change the threshold for codecov to 1%?

@ybiquitous
Copy link
Member

Can we change the threshold for codecov to 1%?

I found the setting for threshold. I'll create a pull request later.
https://docs.codecov.com/docs/codecovyml-reference#coveragenotify

ybiquitous
ybiquitous approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@ybiquitous ybiquitous mentioned this pull request Feb 7, 2022
Merged
@ybiquitous
Copy link
Member

Opened #5892

@jeddy3 jeddy3 merged commit e81473d into main Feb 7, 2022
@jeddy3 jeddy3 deleted the issue-5739 branch February 7, 2022 13:49
@jeddy3
Copy link
Member Author

jeddy3 commented Feb 7, 2022

  • Fixed: no-descending-specificity parseError for double-slash comments within selector lists (#5891).

@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeddy3 @ybiquitous