Skip to content

Fix exit code when nothing is passed to stylelint command #6175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix exit code when nothing is passed to stylelint command #6175

merged 1 commit into from
Jun 27, 2022
+2 −2

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Closes #5150.

Is there anything in the PR that needs further explanation?

Seems too simple - am I missing something?

Also, is this a breaking change? I did change the behaviour that was captured in a test.

@mattxwang
Fix exit code when nothing is passed to stylelint command

Verified

This commit was signed with the committer’s verified signature.
mattxwang Matt Wang
GPG key ID: 6C416627612E5064
Verified
Learn about vigilant mode
19dde18 
Also updates test (breaking behaviour?)
ybiquitous
ybiquitous approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍🏼

I don't want to make this change breaking (that is, need a major update), even if this may be strictly changing the current behavior. Because maybe this would not affect most users.

jeddy3
jeddy3 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jeddy3 jeddy3 merged commit 7124ec3 into main Jun 27, 2022
@jeddy3 jeddy3 deleted the change-empty-exit-code-2 branch June 27, 2022 10:11
@jeddy3
Copy link
Member

jeddy3 commented Jun 27, 2022

  • Fixed: exit code when nothing is passed to stylelint command (#6175).

@sync-by-unito sync-by-unito bot mentioned this pull request Sep 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous

@jeddy3 jeddy3

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix exit code when nothing is passed to stylelint command
3 participants
@mattxwang @jeddy3 @ybiquitous