Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message arguments to declaration-property-unit-allowed-list #6570

Merged
merged 2 commits into from Jan 9, 2023

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6454.

Is there anything in the PR that needs further explanation?

Seems like it should be a simple addition, but perhaps I'm missing something?

Huge thanks to @ybiquitous for doing a great job implementing this feature!

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2023

🦋 Changeset detected

Latest commit: b1bc7ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. I've left a suggestion comment for the changelog, but ready to merge 👍🏼

.changeset/perfect-suits-unite.md Outdated Show resolved Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@mattxwang mattxwang merged commit b4fd2d5 into main Jan 9, 2023
@mattxwang mattxwang deleted the declaration-property-unit-allowed-list-message-args branch January 9, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add message arguments to declaration-property-unit-allowed-list
2 participants