Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selector-attribute-quotes false positives for "never" #6571

Merged
merged 10 commits into from Jan 27, 2023
Merged

Fix selector-attribute-quotes false positives for "never" #6571

merged 10 commits into from Jan 27, 2023

Commits on Jan 9, 2023

  1. First draft: creates isValidIdentifier

    @mattxwang
    mattxwang committed Jan 9, 2023
    Copy the full SHA
    e074a18 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. complete isValidIdentifier, adjust tests, pass in raws value

    @mattxwang
    mattxwang committed Jan 17, 2023
    Copy the full SHA
    7020f8d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into selector-attribute-quotes-never-false-positives

    @mattxwang
    mattxwang committed Jan 17, 2023
    Copy the full SHA
    96c5fcf View commit details
    Browse the repository at this point in the history

  3. add changeset

    @mattxwang
    mattxwang committed Jan 17, 2023
    Copy the full SHA
    2166a35 View commit details
    Browse the repository at this point in the history

  4. use replace instead of replaceAll

    @mattxwang
    mattxwang committed Jan 17, 2023
    Copy the full SHA
    f11bd40 View commit details
    Browse the repository at this point in the history

  5. fix typo

    @mattxwang
    mattxwang committed Jan 17, 2023
    Copy the full SHA
    9462677 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Relax isValidIdentifier to allow custom variables

    @mattxwang
    mattxwang committed Jan 20, 2023
    Copy the full SHA
    a134a67 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Applied suggested refactorings / nits 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jan 26, 2023
    Copy the full SHA
    83c1cab View commit details
    Browse the repository at this point in the history

  2. removes unused function, additional comment

    @mattxwang
    mattxwang committed Jan 26, 2023
    Copy the full SHA
    14c575b View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Make changeset title match guidelines 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jan 27, 2023
    Copy the full SHA
    e6d6781 View commit details
    Browse the repository at this point in the history