Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore: ["custom-elements"] to selector-max-type #6588

Merged
merged 6 commits into from Feb 4, 2023

Conversation

muddv
Copy link
Contributor

@muddv muddv commented Jan 24, 2023

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

No, it's self-explanatory

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023

🦋 Changeset detected

Latest commit: b6a7134

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeddy3 jeddy3 changed the title Add ignore: [custom-elements] to selector-max-type Add ignore: ["custom-elements"] to selector-max-type Jan 24, 2023
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muddv Thank you for contributing. It's looking good. I've made some suggestions to the docs to make them more consistent.

lib/rules/selector-max-type/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/selector-max-type/README.md Outdated Show resolved Hide resolved
lib/rules/selector-max-type/README.md Outdated Show resolved Hide resolved
lib/rules/selector-max-type/README.md Outdated Show resolved Hide resolved
lib/rules/selector-max-type/README.md Outdated Show resolved Hide resolved
lib/rules/selector-max-type/README.md Outdated Show resolved Hide resolved
muddv and others added 2 commits January 24, 2023 21:08
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@muddv
Copy link
Contributor Author

muddv commented Jan 24, 2023

@muddv Thank you for contributing. It's looking good. I've made some suggestions to the docs to make them more consistent.

Thank you for reviewing! I think I fixed everything, sorry for leaving some oversights in.

@muddv muddv requested a review from jeddy3 January 25, 2023 08:21
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muddv Thanks for creating the PR. I point out a typo, but LGTM.

lib/rules/selector-max-type/README.md Outdated Show resolved Hide resolved
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍🏼

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. LGTM.

@jeddy3 jeddy3 merged commit b3af7d2 into stylelint:main Feb 4, 2023
@muddv
Copy link
Contributor Author

muddv commented Feb 4, 2023

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ignore: ["custom-elements"] to selector-max-type
3 participants