-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore: ["custom-elements"]
to selector-max-type
#6588
Conversation
🦋 Changeset detectedLatest commit: b6a7134 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
[custom-elements]
to selector-max-type
ignore: ["custom-elements"]
to selector-max-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muddv Thank you for contributing. It's looking good. I've made some suggestions to the docs to make them more consistent.
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Thank you for reviewing! I think I fixed everything, sorry for leaving some oversights in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muddv Thanks for creating the PR. I point out a typo, but LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. LGTM.
Thanks for reviewing! |
ignore: ["custom-elements"]
toselector-max-type
#6579No, it's self-explanatory