Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor declaration-property-value-no-unknown to reuse parsed CSSTree node #6616

Merged
merged 1 commit into from Feb 6, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Feb 6, 2023

Which issue, if any, is this issue related to?

Follow-up for #6511

Is there anything in the PR that needs further explanation?

According to the CSSTree doc, it is likely a typical case to pass a node to lexer.matchProperty().

CSSTree Usage
// parse CSS to AST as a declaration value
const ast = csstree.parse('red 1px solid', { context: 'value' });

// match to syntax of `border` property
const matchResult = csstree.lexer.matchProperty('border', last);

I guess this change may reduce extra parsing, but I'm not sure about the implementation details of CSSTree.

…no-unknown`

According to the [CSSTree doc](https://github.com/csstree/csstree/blob/v2.3.1/README.md#usage),
it is likely a typical case to pass a node to `lexer.matchProperty()`.
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023

⚠️ No Changeset found

Latest commit: 8e0e697

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jeddy3 jeddy3 changed the title Refactor to reuse parsed CSSTree node in declaration-property-value-no-unknown Refactor declaration-property-value-no-unknown to reuse parsed CSSTree node Feb 6, 2023
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jeddy3 jeddy3 merged commit bf9f222 into v15 Feb 6, 2023
@jeddy3 jeddy3 deleted the follow-up-pr-6511 branch February 6, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants