Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function-calc-no-unspaced-operator TypeError on empty calc() #6634

Conversation

romainmenke
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6633

Is there anything in the PR that needs further explanation?

calc() is not valid, or useful but it also isn't an error that is related to this rule specifically.

This rule should not throw when processing calc()

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023

🦋 Changeset detected

Latest commit: 9129ce6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@romainmenke
Copy link
Member Author

This PR includes no changesets

I would like to resolve this, but I am unsure which steps to take.

@jeddy3 jeddy3 changed the title function-calc-no-unspaced-operator: fix exception on empty calc Fix function-calc-no-unspaced-operator TypeError on empty calc() Feb 10, 2023
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One minor nit, but looks good otherwise.

I would like to resolve this, but I am unsure which steps to take.

Click the "Click here if you're a maintainer who wants to add a changeset to this PR" link and add:

"Fixed: function-calc-no-unspaced-operator TypeError on empty calc()"

(PR conventions)

lib/rules/function-calc-no-unspaced-operator/index.js Outdated Show resolved Hide resolved
romainmenke and others added 2 commits February 10, 2023 11:46
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@romainmenke
Copy link
Member Author

Thank you for the feedback!
Hopefully the changeset was done right :)

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🏼

@ybiquitous ybiquitous added this pull request to the merge queue Feb 10, 2023
Merged via the queue into stylelint:main with commit c64065e Feb 10, 2023
@romainmenke romainmenke deleted the fix-error-on-empty-calc--philosophical-duck-6517ddde0b branch February 10, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix function-calc-no-unspaced-operator TypeError on empty calc()
3 participants