Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declaration-property-value-no-unknown false positives for env() #6646

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Feb 10, 2023

Which issue, if any, is this issue related to?

Closes #6635

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023

🦋 Changeset detected

Latest commit: aee9f10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic to see the pull request upstream too!

Two minor nits, but otherwise LGTM.

Let's change:

containsUnsupportedMathFunction() -> containsUnsupportedFunction().

.changeset/serious-moose-applaud.md Outdated Show resolved Hide resolved
romainmenke and others added 2 commits February 10, 2023 19:00
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.

LGTM.

@romainmenke romainmenke added this pull request to the merge queue Feb 10, 2023
Merged via the queue into main with commit d24ee3b Feb 10, 2023
@romainmenke romainmenke deleted the fix-declaration-property-value-no-unknown-false-positive-for-env-function--inventive-jack-russel-26484f1f7c branch February 10, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix declaration-property-value-no-unknown false positives for env()
2 participants