Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value-keyword-case false positives for Level 4 system colours #6712

Merged
merged 2 commits into from Mar 14, 2023

Conversation

thewilkybarkid
Copy link
Contributor

This adds the CSS Color Module Level 4 system colours to the list of keywords that are not changed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

🦋 Changeset detected

Latest commit: 3d3665a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeddy3
Copy link
Member

jeddy3 commented Mar 14, 2023

@thewilkybarkid Thanks for the pull request. Am I right in assuming this is to fix false positives in value-keyword-case?

@thewilkybarkid
Copy link
Contributor Author

@jeddy3 That's right; some deprecated keywords (e.g. ActiveBorder) are already supported.

@jeddy3 jeddy3 changed the title Ignore CSS Color Module Level 4 system colours Fix value-keyword-case false positives for Level 4 system colours Mar 14, 2023
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍🏼

@ybiquitous ybiquitous merged commit 5d46c7d into stylelint:main Mar 14, 2023
@thewilkybarkid thewilkybarkid deleted the css-color-4-system branch March 14, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants