Fix rule-selector-property-disallowed-list secondary options

[mattxwang]

Which issue, if any, is this issue related to?

Closes #6688.

Is there anything in the PR that needs further explanation?

I'm a bit confused why this wasn't caught by the test suite when the rule was first made/messages were added; presumably, I should write a regression test here. Any suggestions?

[changeset-bot]

🦋 Changeset detected

Latest commit: a510502

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ybiquitous]

@mattxwang Thanks for creating the pull request!

I'm a bit confused why this wasn't caught by the test suite when the rule was first made/messages were added; presumably, I should write a regression test here. Any suggestions?

Because the current test suite does not specify a message secondary option. If we add a regression test case, the following can be considered:

// lib/rules/rule-selector-property-disallowed-list/__tests__/index.js
testRule({
	ruleName,
	config: [{ a: 'color' }, { message: 'foo' }],

	reject: [
		{
			code: 'a { color: red; }',
			message: 'foo',
			description: 'custom message',
		},
	],
});

---

Incidentally, how about also fixing the position of ↑ in the rule's doc suggested in #6688 (comment)? The second ↑ should point the property name instead of the value.

stylelint/lib/rules/rule-selector-property-disallowed-list/README.md

Lines 7 to 9 in 0bc53af

	a { color: red; }
	/** ↑ ↑
	* Selector and property name */

[mattxwang]

Thanks for the quick response, and sorry for the delay! I confirmed that the test case you suggested catches the bug, and that removing that one line resolves it. Have also updated the doc arrow to point at color!

[ybiquitous]

Thank you. LGTM 👍🏼

[ybiquitous]

(off-topic) Hi @mattxwang,

Since @jeddy3 will be offline for a while (maybe a few months), could you please help me with the repository maintenance when you have time?

[mattxwang]

could you please help me with the repository maintenance when you have time?

Of course! Didn't realize that @jeddy3 is offline. I can certainly review more PRs and help out with dependencies, etc.

[ybiquitous]

Thank you! 😊