Add media-feature-range-notation autofix
#6742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b854a03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
romainmenke
commented
Mar 28, 2023
ybiquitous
reviewed
Mar 29, 2023
There was a problem hiding this comment.
@romainmenke Thanks for the pull request. Great work! 👏🏼
I've left a few suggestions, but this change has no big problems. 👍🏼
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
Thank you for the review and feedback @ybiquitous 🙇 |
ybiquitous
reviewed
Mar 29, 2023
| @@ -228,7 +228,7 @@ Enforce one representation of things that have multiple with these `notation` (s | |||
| - [`hue-degree-notation`](../../lib/rules/hue-degree-notation/README.md): Specify number or angle notation for degree hues (Autofixable) (Ⓢ). | |||
| - [`import-notation`](../../lib/rules/import-notation/README.md): Specify string or URL notation for `@import` rules (Autofixable) (Ⓢ). | |||
| - [`keyframe-selector-notation`](../../lib/rules/keyframe-selector-notation/README.md): Specify keyword or percentage notation for keyframe selectors (Autofixable) (Ⓢ). | |||
| - [`media-feature-range-notation`](../../lib/rules/media-feature-range-notation/README.md): Specify context or prefix notation for media feature ranges. | |||
| - [`media-feature-range-notation`](../../lib/rules/media-feature-range-notation/README.md): Specify context or prefix notation for media feature ranges (Autofixable) (Ⓢ). | |||
There was a problem hiding this comment.
[note] Good catch to support the standard config. 👍🏼
ybiquitous
approved these changes
Mar 29, 2023
ybiquitous
deleted the
add-fix-support-for-media-feature-range-notation--resourceful-harrier-c39c531fed
branch
|
Unable to parse when : less file: @media screen and(width <= @screen-sm-max) {
.topbox {
// code
}
}Need to add spaces manually: @media screen and (width <= @screen-sm-max) {
.topbox {
// code
}
} |
|
@yoyo837 Thanks for the report. Can you open a new issue with reproducible info, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6501
Some bits are more complex/messy than I would like but I held of on trying to abstract this.
I personally prefer to only abstract away complexity after having found ±3 use cases.
But I don't mind spending time on refactors now if people with more experience in this code base have good ideas on how to improve this :)