Fix color-function-notation false positives for namespaced imports
#6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 99be065 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mattxwang Thanks for the pull request. Do you know why the title has whitespace between |
mattxwang
changed the title
color-function notation false positives for namespaced importscolor-function-notation false positives for namespaced imports
Ah! My mistake, I think I just copy-pasted the changeset incorrectly. Let me fix! |
|
Thanks, it was just a copy-and-paste mistake. Don't mind. 😄 👍🏼 |
ybiquitous
approved these changes
Apr 11, 2023
mattxwang
deleted the
fix-color-function-notation-namespaced-imports-false-positive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6610.
Ref for searching for
.$: SCSS highlights those characters as errors for invalid namespace imports.I noticed that
rgbawas misspelt in some of the test cases forisStandardSyntaxColorFunction.test.js, so I've changed those too.