Remove 76 rules deprecated in 15.0.0 #6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methodology:
- remove each `lib/rules/*` for each deprecated test
- remove each (now invalid) path from `lib/rules/index.js`
- fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- tests that are *about* deprecated rules; I added a `.skip`
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted this
In contrast, I have not:
- removed now-unused utilities
- removed now-unused packages (not sure if these exist)
🦋 Changeset detectedLatest commit: aef7b5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattxwang
commented
Jun 26, 2023
|
How about creating a |
|
Sounds good! I'll wrap up one more local change and then retarget this PR! |
mattxwang
commented
Jun 26, 2023
ybiquitous
reviewed
Jun 26, 2023
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
[ask] Just to confirm about |
|
@mattxwang Thanks for getting the ball rolling on this! I've pushed a commit to move the list of deprecated rules into the corresponding section of the 15.0.0 migration guide. We can include a link to the section from our migrating to 16.0.0 guide, which we should create as part of this pull request. Something along the lines of "We've removed the stylistic rules we deprecated in |
jeddy3
reviewed
Jun 26, 2023
There was a problem hiding this comment.
Can any of the dependencies be removed? I suspect style-search is redundant, as only the older stylistic rules used it.
Agree. 👍🏼 FYI, here's the output of the tool $ npx depcheck@latest
...
Unused dependencies
* style-search
...(also |
|
Since no one was against tackling them all at once, I surmise this PR can be reviewed. |
Mouvedia
reviewed
Jun 26, 2023
Mouvedia
reviewed
Jun 26, 2023
Mouvedia
reviewed
Jun 26, 2023
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
pushed a commit
that referenced
this pull request
Jul 8, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Jul 8, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Jul 8, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Jul 13, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Jul 13, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Jul 20, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Jul 20, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Jul 24, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Jul 24, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Jul 25, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Jul 25, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Jul 26, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Jul 26, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Jul 26, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Jul 26, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Jul 27, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Jul 27, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Aug 12, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Aug 12, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Aug 14, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Aug 14, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Aug 27, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Aug 27, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Aug 27, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Aug 27, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Sep 28, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Sep 28, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
ybiquitous
pushed a commit
that referenced
this pull request
Oct 19, 2023
I'll quickly explain the methodology for this PR:
1. remove each `lib/rules/*` for each deprecated test
2. remove each (now invalid) path from `lib/rules/index.js`
3. fix all broken tests, which fall into one of several categories:
- tests that use a deprecated rule as an arbitrary rule; to resolve this, I just picked a different rule (usually `color-named` for `color-hex-case` and `number-max-precision` for `indentation`)
- one of these is about a custom plugin, so I've rewritten the plugin
- tests that are *about* deprecated rules; I added a `.skip` (have left comments in the review)
- fs tests that use deprecated rules; I removed these from the config, then updated the snapshot.
- the zen garden one doesn't work "out of the box" anymore, i.e. the snapshot has nontrivially changed because of indentation/spacing rules
- `indentation`-specific behaviour (it being last); I deleted these!
4. remove all documentation related to removed rules (mostly `indentation`)
5. remove all unused utilities (via code coverage, not manual inspection)
ybiquitous
pushed a commit
that referenced
this pull request
Oct 19, 2023
Ref: #6979 (comment) Re-running the script indicates no newly-unused files: ```sh $ node scripts/find-unused-modules.mjs ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6961.
I apologize for how large this change is 😅 I'm not sure if this is easier to review (since it is clean + accomplishes it in one go), or if we'd prefer one that splits them up piecemeal (e.g. into sections) - let me know what we'd prefer!
I'll quickly explain the methodology for this PR:
lib/rules/*for each deprecated testlib/rules/index.jscolor-namedforcolor-hex-caseandnumber-max-precisionforindentation).skip(have left comments in the review)indentation-specific behaviour (it being last); I deleted these!indentation)