Add support JS objects for extends config option #6998
Merged
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a5d8357 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fpetrakov
changed the title
mattxwang
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Thanks for submitting a PR @fpetrakov! Do you mind adding a test case (or a few) that validate the behaviour you've added?
(you'll also want to add a changeset, which you can do with npx changeset; since this adds a feature, this is likely a minor change)
|
@fpetrakov Thanks for the pull request. Could you please add a test case to |
|
@ybiquitous just added the test case. Would you mind reviewing it? |
ybiquitous
changed the title
ybiquitous
approved these changes
Jul 3, 2023
Mouvedia
reviewed
Jul 3, 2023
Mouvedia
reviewed
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6952.
No, it's self-explanatory.