Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node.js 14 support #7020

Merged
merged 2 commits into from Jul 1, 2023
Merged

Remove Node.js 14 support #7020

merged 2 commits into from Jul 1, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Jun 30, 2023

Which issue, if any, is this issue related to?

Closes #6740
Closes #6785
(Unfortunately, the PR's author doesn't respond)

Is there anything in the PR that needs further explanation?

Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0


Here's a ls-engines report:

$ npx ls-engines@latest
`node_modules` found; loading tree from disk...
┌────────┬─────────────────────────────────────────────────────────────────┐
│ engine │ Currently available latest release of each valid major version: │
├────────┼─────────────────────────────────────────────────────────────────┤
│ node   │ v20.3.1, v19.9.0, v18.16.1, v17.9.1, v16.20.1                   │
└────────┴─────────────────────────────────────────────────────────────────┘

┌───────────────────────────────────┬───────────────────────────┐
│ package engines:                  │ dependency graph engines: │
├───────────────────────────────────┼───────────────────────────┤
│ "engines": {                      │ "engines": {              │
│   "node": "^16.13.0 || >= 18.0.0" │   "node": ">= 16.13"      │
│ }                                 │ }                         │
└───────────────────────────────────┴───────────────────────────┘


Your “engines” field allows fewer node versions than your dependency graph does.

If you want to widen your support, you can run `ls-engines --save`, or manually add the following to your `package.json`:
"engines": {
  "node": ">= 16.13"
}

┌────────┬─────────────────┬─────────────────┬──────────────────────────┐
│ engine │ current version │ valid (package) │ valid (dependency graph) │
├────────┼─────────────────┼─────────────────┼──────────────────────────┤
│ node   │ v20.3.0         │ yes!            │ yes!                     │
└────────┴─────────────────┴─────────────────┴──────────────────────────┘

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: f194ae7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ybiquitous ybiquitous changed the title Remove Node.js 12 support Remove Node.js 14 support Jun 30, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
@ybiquitous ybiquitous marked this pull request as ready for review June 30, 2023 16:30
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mouvedia
Copy link
Member

In the same way as

- removed support for Node.js 12

we need a breaking change(s) section for to-16.

@ybiquitous
Copy link
Member Author

@Mouvedia Good catch! Updated via f194ae7.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@ybiquitous ybiquitous merged commit d9f5cd7 into v16 Jul 1, 2023
13 checks passed
@ybiquitous ybiquitous deleted the remove-node-14 branch July 1, 2023 12:49
ybiquitous added a commit that referenced this pull request Jul 1, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 3, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 3, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
mattxwang pushed a commit that referenced this pull request Jul 4, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
mattxwang pushed a commit that referenced this pull request Jul 4, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 6, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 8, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 8, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 13, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 20, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 24, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 25, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 26, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 26, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Jul 27, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Aug 12, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Aug 14, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Aug 27, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Aug 27, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Sep 28, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
ybiquitous added a commit that referenced this pull request Oct 19, 2023
Node.js 16.13.0 is the first version of Node.js 16.x LTS series.
See https://nodejs.org/en/blog/release/v16.13.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants