Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Node.js API returned resolved object change #7183

Merged
merged 7 commits into from Sep 27, 2023
Merged

Revert Node.js API returned resolved object change #7183

merged 7 commits into from Sep 27, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes #7141
Follow-up to #7119 (partially reverted)

Is there anything in the PR that needs further explanation?

This Pull Request does:

  • reverts the output property change in Node.js API returned promise object
  • deprecates the output property
  • adds a new report property instead of output

@ybiquitous
Revert Node.js API returned resolved object change
9019563 
This commit does:
- reverts the `output` property change in Node.js API returned promise object
- deprecates the `output` property
- adds a new `report` property instead of `output`
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023 •
edited

🦋 Changeset detected

Latest commit: ef631f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ybiquitous ybiquitous marked this pull request as ready for review September 12, 2023 01:11
@ybiquitous ybiquitous linked an issue Sep 12, 2023 that may be closed by this pull request
Revert Node.js API returned resolved object change #7141
Closed
mattxwang
mattxwang reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slowly catching up on the context, but this generally looks good to me. left a few minor nits!

types/stylelint/index.d.ts Outdated Show resolved Hide resolved
types/stylelint/index.d.ts Outdated Show resolved Hide resolved
.changeset/wise-parents-rule.md Outdated Show resolved Hide resolved
Mouvedia
Mouvedia reviewed Sep 19, 2023
View reviewed changes
lib/standalone.mjs Outdated Show resolved Hide resolved
mattxwang
mattxwang approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if @Mouvedia has other comments left, but from my perspective this LGTM.

It's a bit of a bummer that code coverage through codecov is not working super well with the ESM migration. I'm happy to help wrap that up as we merge in the final v16 branch, since I'm sure I will have missed some things.

@ybiquitous
Copy link
Member Author

ybiquitous commented Sep 22, 2023 •
edited

Yeah, decreasing coverage is a headache. I guess this is caused by *.cjs addition. And I'll add test cases for CJS after rewriting to ESM, in order to improve CJS coverage.

@ybiquitous ybiquitous merged commit 37413b4 into v16 Sep 27, 2023
13 of 14 checks passed
@ybiquitous ybiquitous deleted the issue-7141 branch September 27, 2023 23:04
@ybiquitous ybiquitous mentioned this pull request Sep 27, 2023
Closed
ybiquitous added a commit that referenced this pull request Sep 28, 2023
@ybiquitous @mattxwang
Revert Node.js API returned resolved object change (#7183)
0ec8138 
This commit does:
- reverts the `output` property change in Node.js API returned promise object
- deprecates the `output` property
- adds a new `report` property instead of `output`

Co-authored-by: Matt Wang <matt@matthewwang.me>
@Mouvedia
Copy link
Member

Mouvedia commented Oct 11, 2023 •
edited

@ybiquitous not really a big deal right now but you forgot to remove https://github.com/stylelint/stylelint/blob/v16/.changeset/thin-guests-smell.md
It needs to be done before the merge into main.

@ybiquitous ybiquitous mentioned this pull request Oct 11, 2023
Merged
ybiquitous added a commit that referenced this pull request Oct 11, 2023
@ybiquitous
Remove unneeded changelog entry
f83146f 
Follow-up to #7183
@ybiquitous
Copy link
Member Author

@Mouvedia Thanks. I completely forgot it. Opened PR #7227

ybiquitous added a commit that referenced this pull request Oct 11, 2023
@ybiquitous
Remove unneeded changelog entry (#7227)
24f3bc5 
Follow-up to #7183
ybiquitous added a commit that referenced this pull request Oct 19, 2023
@ybiquitous @mattxwang
Revert Node.js API returned resolved object change (#7183)
4960a3e 
This commit does:
- reverts the `output` property change in Node.js API returned promise object
- deprecates the `output` property
- adds a new `report` property instead of `output`

Co-authored-by: Matt Wang <matt@matthewwang.me>
ybiquitous added a commit that referenced this pull request Oct 19, 2023
@ybiquitous
Remove unneeded changelog entry (#7227)
7b3f6e9 
Follow-up to #7183
@ybiquitous ybiquitous mentioned this pull request Nov 6, 2023
Merged
ybiquitous added a commit that referenced this pull request Nov 6, 2023
@ybiquitous
Refactor tests to remove deprecated output property as possible
6f33d90 
This change aims to reduce redundant warnings in test reports.
Note that it still cannot be removed completely where needed.

Follow-up to #7183
ybiquitous added a commit that referenced this pull request Nov 6, 2023
@ybiquitous
Refactor tests to remove deprecated output property as possible (#7300
c98f02b 
)

This change aims to reduce redundant warnings in test reports.
Note that it still cannot be removed completely where needed.

Follow-up to #7183
@jeddy3 jeddy3 mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mouvedia Mouvedia Mouvedia left review comments

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert Node.js API returned resolved object change
3 participants
@ybiquitous @Mouvedia @mattxwang