Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner to generated CJS files by Rollup #7282

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Ref #5291

Is there anything in the PR that needs further explanation?

This change aims to prevent developers' misunderstandings.

For the output.banner option of Rollup, see https://rollupjs.org/configuration-options/#output-banner-output-footer.

@changeset-bot

This comment was marked as resolved.

rollup.config.mjs Outdated Show resolved Hide resolved
ybiquitous and others added 2 commits October 30, 2023 08:29
Co-authored-by: Matt Wang <matt@matthewwang.me>
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ybiquitous ybiquitous merged commit a654161 into v16 Oct 30, 2023
14 checks passed
@ybiquitous ybiquitous deleted the add-banner-to-generated-cjs-files branch October 30, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants