New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ESM custom formatters #7343
Conversation
This change adds the support for ESM custom formatters. A custom formatter can be specified via CLI. Also, this change refactors code as below to reduce the published size: - move the logic in `lib/resolveCustomFormatter.{cjs,mjs}` files into `cli.mjs` - remove the files
🦋 Changeset detectedLatest commit: d896cd7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
import cli, { buildCLI } from '../cli.mjs'; | ||
|
||
const pkg = readJSONFile(new URL('../../package.json', import.meta.url)); | ||
|
||
const fixturesPath = (...elems) => | ||
replaceBackslashes(path.join(fileURLToPath(new URL('./fixtures', import.meta.url)), ...elems)); | ||
|
||
jest.unstable_mockModule('stylelint-test-custom-formatter', () => ({ default: customFormatter })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you.
Let's add an entry to the migration guide too. (It's okay if there's repetition at this stage as we can give the guide a clean-up before releasing.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
Closes #7267
This PR adds the support for ESM custom formatters. A custom formatter can be specified via CLI.
Also, this change refactors code as below to reduce the published size:
lib/resolveCustomFormatter.{cjs,mjs}
files intocli.mjs