Add support for ESM custom syntaxes #7351
Merged
+168
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab38fa2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ybiquitous
commented
Nov 20, 2023
| } catch (error) { | ||
| if ( | ||
| error && | ||
| typeof error === 'object' && | ||
| 'code' in error && | ||
| error.code === 'MODULE_NOT_FOUND' && | ||
| (error.code === 'MODULE_NOT_FOUND' || error.code === 'ERR_MODULE_NOT_FOUND') && |
There was a problem hiding this comment.
[note] The path of error.code === 'ERR_MODULE_NOT_FOUND' is not covered in tests for some reason. I guess Babel under Jest may transform the import() code, but I'm not sure.
Mouvedia
reviewed
Nov 20, 2023
Mouvedia
reviewed
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7269
The dynamic
import()supports both ESM and CJS.