Fix ERR_UNSUPPORTED_ESM_URL_SCHEME error on Windows

[JounQin]

Which issue, if any, is this issue related to?

close #7382

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2bd6507

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jeddy3]

@JounQin Thank you for looking into this!

Is it possible to add tests to cover this scenario?

And do we also need to use this approach for plugins and custom formatters?

(FYI, I removed the bug label to be consistent with our guidelines).

[JounQin]

Is it possible to add tests to cover this scenario?

I'm not quite familiar with how to test such edge cases.

And do we also need to use this approach for plugins and custom formatters?

If they may be loaded with absolute path, then yes, otherwise there is no need do it.

(FYI, I removed the bug label to be consistent with our guidelines).

Can we remove such unused labels in repository preset?

[JounQin]

@ybiquitous I think the latest change e547bf4 requested makes more problems than it wants to resolve.

I think we should just revert this commit, only import() will be affected by this issue.

[ybiquitous]

@JounQin Can we fix getModulePath() instead as #7382 (comment)?

[JounQin]

@ybiquitous #7383 (comment)

[ybiquitous]

more problems than it wants to resolve

Just curious, what problem?

[JounQin]

@ybiquitous https://github.com/stylelint/stylelint/actions/runs/7158350468?pr=7383

[ybiquitous]

Ah, you didn't need to force-push since we couldn't find the failed CI easily.

[ybiquitous]

I found the failure cause of e547bf4. The extends config doesn't use dynamic import(). So, we cannot fix getModulePath() now.

However, I think we must fix dynamic import() also plugins, not only custom syntaxes:

stylelint/lib/augmentConfig.mjs

Line 320 in 2a82f4d

pluginImport = await import(pluginLookup);

So, how about adding a tiny utility to wrap dynamic import()? For example,

// lib/utils/dynamicImport.mjs
export default dynamicImport(path) {
  const fixedPath = isAbsolute(path) ? pathToFileURL(path).toString() : path;

  return import(fixedPath);
}

[JounQin]

Sure, a tiny util is fine enough. I didn't find that usage previously. Wait minutes.

[ybiquitous]

Thanks a lot! LGTM 👍🏼

[CrOrc]

The same error is thrown in cli.mjs when running
stylelint "**/*.css" --custom-formatter="./path/to/formatter.js"

[JounQin]

@CrOrc You need to create a new issue with online and runnable reproduction.