Fix ERR_UNSUPPORTED_ESM_URL_SCHEME for --custom-formatter on Windows
#7432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: febb16a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jeddy3
changed the title
dynamicImport util for Windows compatibilityERR_UNSUPPORTED_ESM_URL_SCHEME for --custom-formatter on Windows
jeddy3
reviewed
Dec 30, 2023
There was a problem hiding this comment.
@JounQin Thank you for the PR!
I updated the title, changelog entry and label to match our conventions.
I've asked the original reporter to test this branch. Let's merge once they confirm it resolves the issue for them.
|
LGTM, too! Let's wait for the reporter's confirmation. |
jeddy3
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7428
No, it's self-explanatory.