Fix declaration-property-value-no-unknown false negatives for @starting-style
#7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2956d08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mouvedia
reviewed
Jan 13, 2024
ybiquitous
requested changes
Jan 14, 2024
There was a problem hiding this comment.
@fpetrakov Thanks for the follow-up pull request! I've commented on the refactoring as @Mouvedia suggested. Can you address it?
ybiquitous
changed the title
declaration-property-value-no-unknown false negatives for @starting-style
Mouvedia
reviewed
Jan 14, 2024
| @@ -11,6 +11,9 @@ testRule({ | |||
| { | |||
| code: 'a { top: 0; }', | |||
| }, | |||
| { | |||
| code: 'a { @starting-style { opacity: 0; } }', | |||
There was a problem hiding this comment.
minor nit
- the color property by default
- the red value by default
Since the rest of the examples don't respect it, you don't have to though.
cf https://stylelint.io/developer-guide/rules#write-tests
Mouvedia
approved these changes
Jan 14, 2024
jeddy3
requested changes
Jan 15, 2024
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
jeddy3
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None, it's a false negative fix for
declaration-property-value-no-unknownrule.This false negative is explained here - #7438 (comment)